Alliance credits you have earned will not be lost if you change to a new alliance. After joining the new alliance, you will have the same amount of alliance credits you had left over in your previous alliance